Github user mike-jumper commented on a diff in the pull request:

    
https://github.com/apache/incubator-guacamole-client/pull/109#discussion_r98336745
  
    --- Diff: guacamole/src/main/java/org/apache/guacamole/rest/APIRequest.java 
---
    @@ -42,6 +42,16 @@
         private final Map<String, String[]> parameters;
     
         /**
    +     * The remote hostname that initiated the request.
    +     */
    +    private final String remoteHost;
    +
    +    /**
    +     * The remote ip address that initiated the request.
    --- End diff --
    
    Perhaps a bit of a semantic nitpick, but this is not the IP address that 
initiated the request, because IP addresses can't do things. It's the IP 
address of the client that initiated the request. Same thing for the hostname 
above.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to