GitHub user necouchman opened a pull request:
https://github.com/apache/incubator-guacamole-client/pull/132
GUACAMOLE-101: Allow Filtering of LDAP Users
Took a stab at implementing two LDAP filter configuration properties for
user and connection searches.
This was a very quick stab at implementing it - there are a couple of
things that might be worth adding:
- Error checking on the LDAP query - not sure if there's an easy way to
parse out the filters to make sure that they're valid before actually running
the searches?? The LDAPException should handle this - there are specific
messages for filter errors.
- The JIRA issue mentions implementing multiple search bases - this does
not do anything with that.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/necouchman/incubator-guacamole-client
GUACAMOLE-101
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-guacamole-client/pull/132.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #132
----
commit e5daa1fc7d50d1dc1cccf7c6756a3f572edde1d7
Author: Nick Couchman <[email protected]>
Date: 2017-03-21T02:15:14Z
GUACAMOLE-101: Impelement properties for controller user and connection
search filters.
commit e8629237b8ffee941eb2bf9eda62bb3e8e341571
Author: Nick Couchman <[email protected]>
Date: 2017-03-21T02:29:55Z
GUACAMOLE-101: Update comments to some of the changes.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
