Github user mike-jumper commented on a diff in the pull request:
https://github.com/apache/incubator-guacamole-client/pull/132#discussion_r108457046
--- Diff:
extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/user/UserService.java
---
@@ -85,11 +85,22 @@ private void putAllUsers(Map<String, User> users,
LDAPConnection ldapConnection,
try {
+ // Build a filter using the configured or default user search
filter
+ // to find all user objects in the LDAP tree
+ StringBuilder userSearchFilter = new StringBuilder();
+ userSearchFilter.append("(&");
+ userSearchFilter.append(confService.getUserSearchFilter());
+ userSearchFilter.append("(");
+
userSearchFilter.append(escapingService.escapeLDAPSearchFilter(usernameAttribute));
+ userSearchFilter.append("=*)");
+ userSearchFilter.append(")");
+
+
--- End diff --
Please kill one of these blank lines - separating things by two blanks is
somewhat unusual compared to the surrounding code.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
