Github user mike-jumper commented on a diff in the pull request:

    
https://github.com/apache/incubator-guacamole-client/pull/158#discussion_r118811859
  
    --- Diff: 
extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/base/ModeledDirectoryObjectService.java
 ---
    @@ -97,9 +97,12 @@
          *
          * @return
          *     An object which is backed by the given model object.
    +     *
    +     * @throws GuacamoleException
    +     *     If the object instance cannot be created.
          */
         protected abstract InternalType 
getObjectInstance(ModeledAuthenticatedUser currentUser,
    -            ModelType model);
    +            ModelType model) throws GuacamoleException;
    --- End diff --
    
    Ah - because `getObjectInstance()` now needs to call 
`hasObjectPermission()`, at least in the user case. See:
    
    
https://github.com/mike-jumper/incubator-guacamole-client/blob/232935fe2cd81077c81bed6079707e3a41ceb9fb/extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/user/UserService.java#L161-L162


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to