Github user mike-jumper commented on a diff in the pull request:
https://github.com/apache/incubator-guacamole-client/pull/158#discussion_r118812173
--- Diff: guacamole/src/main/webapp/app/form/directives/form.js ---
@@ -163,6 +181,59 @@ angular.module('form').directive('guacForm', [function
form() {
});
+ /**
+ * Returns whether the given field should be displayed to the
+ * current user.
+ *
+ * @param {Field} field
+ * The field to check.
+ *
+ * @returns {Boolean}
+ * true if the given field should be visible, false
otherwise.
+ */
+ $scope.isVisible = function isVisible(field) {
+
+ // Forms with valuesOnly set should display only fields
with
+ // associated values in the model object
+ if ($scope.valuesOnly)
--- End diff --
Yep. It's definitely not needed by these changes, and the changes which
*did* need it were ultimately reverted.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
