Github user mike-jumper commented on a diff in the pull request:

    
https://github.com/apache/incubator-guacamole-server/pull/93#discussion_r119493341
  
    --- Diff: src/protocols/ssh/settings.c ---
    @@ -165,6 +166,12 @@ enum SSH_ARGS_IDX {
          */
         IDX_READ_ONLY,
     
    +    /**
    +     * Number of seconds between sending alive packets.  A default of 0
    --- End diff --
    
    The [documentation for 
`libssh2_keepalive_config()`](https://www.libssh2.org/libssh2_keepalive_config.html)
 defines some behavior which will make this not exactly correct:
    
    > To avoid some busy-loop corner-cases, if you specify an interval of 1 it 
will be treated as 2.
    
    That oddity will need to be documented. Perhaps we should just define 2 as 
the minimum value allowed?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to