Github user necouchman commented on a diff in the pull request:

    
https://github.com/apache/incubator-guacamole-server/pull/93#discussion_r119500395
  
    --- Diff: src/protocols/ssh/ssh.c ---
    @@ -331,6 +343,18 @@ void* ssh_client_thread(void* data) {
                 break;
             }
     
    +        /* Send keepalive at configured interval */
    +        if (settings->server_alive_interval > 0) {
    +            alive = libssh2_keepalive_send(ssh_client->session->session, 
&timeout);
    +            /* Sending the keepalive failed, so we break out */
    +            if (alive > 0)
    +                break;
    +            sleep = timeout * 1000;
    +        }
    +        /* If keepalive is not configured, sleep for the default of 1 
second */
    +        else
    +            sleep = 1000;
    --- End diff --
    
    Defined GUAC_SSH_DEFAULT_POLL_TIMER in settings.h and used that here, 
instead.  Is that placement/name okay?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to