GitHub user dotmaster opened a pull request:

    https://github.com/apache/incubator-guacamole-client/pull/174

    GUACAMOLE-341: Make SSO Authentication work and pass through username…

    … to RDP session
    
    To make tokenfilter work with auth-header and noauth module. (needed e.g. 
for Kerberos authentication through an Apache/Nginx Reverse Proxy, that passes 
REMOTE_USER header), username must be set in the credentials object, because it 
is added to the Tokenfilter only if username is not null in the credentials 
object.
    basically make $
    {GUAC_USERNAME}
    be replaced with the credentials passed though the REMOTE_USER variable.
    See also:
    
https://github.com/glyptodon/guacamole-client/blob/b26a664d66fd14a22eb7300d29aa20390cf408ec/guacamole-ext/src/main/java/org/apache/guacamole/token/StandardTokens.java#L118
    
https://github.com/glyptodon/guacamole-client/blob/0.9.12-incubating/guacamole-ext/src/main/java/org/apache/guacamole/net/auth/simple/SimpleAuthenticationProvider.java#L170

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dotmaster/incubator-guacamole-client patch-1

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-guacamole-client/pull/174.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #174
    
----
commit 7c408534ce4bfd3093ae2d9cca2de56c0cb826e2
Author: dotmaster <[email protected]>
Date:   2017-07-07T12:29:34Z

    GUACAMOLE-341: Make SSO Authentication work and pass through username to 
RDP session
    
    To make tokenfilter work with auth-header and noauth module. (needed e.g. 
for Kerberos authentication through an Apache/Nginx Reverse Proxy, that passes 
REMOTE_USER header), username must be set in the credentials object, because it 
is added to the Tokenfilter only if username is not null in the credentials 
object.
    basically make $
    {GUAC_USERNAME}
    be replaced with the credentials passed though the REMOTE_USER variable.
    See also:
    
https://github.com/glyptodon/guacamole-client/blob/b26a664d66fd14a22eb7300d29aa20390cf408ec/guacamole-ext/src/main/java/org/apache/guacamole/token/StandardTokens.java#L118
    
https://github.com/glyptodon/guacamole-client/blob/0.9.12-incubating/guacamole-ext/src/main/java/org/apache/guacamole/net/auth/simple/SimpleAuthenticationProvider.java#L170

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to