Github user mike-jumper commented on a diff in the pull request:
https://github.com/apache/incubator-guacamole-client/pull/174#discussion_r126162449
--- Diff:
extensions/guacamole-auth-header/src/main/java/org/apache/guacamole/auth/header/AuthenticationProviderService.java
---
@@ -71,6 +71,9 @@ public AuthenticatedUser authenticateUser(Credentials
credentials)
// Get the username from the header configured in
guacamole.properties
String username =
request.getHeader(confService.getHttpAuthHeader());
+
+ //write username to the credentials object to make tokenfilter
work
--- End diff --
Please follow the existing code style. Compare:
> //write username to the credentials object to make tokenfilter work
vs. other comments in incubator-guacamole-client:
> // Get the username from the header configured in guacamole.properties
Relative to the established style, this comment is missing the space
following `//`, and should be in sentence case (first letter capitalized).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
