GitHub user mike-jumper opened a pull request:
https://github.com/apache/incubator-guacamole-client/pull/176
GUACAMOLE-346: Avoid blocking main thread when seeking.
For sufficiently large recordings, the existing implementation of
`Guacamole.SessionRecording` can potentially block the main thread to the point
that the script appears to have hung. This change modifies
`Guacamole.SessionRecording` such that seek operations are performed
asynchronously, with completion of the seek reported through a callback.
The playback example has been modified accordingly, providing a
notification and cancel button for in-progress seek operations.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mike-jumper/incubator-guacamole-client
async-seek
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-guacamole-client/pull/176.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #176
----
commit 1d6e8d2216adbebc1c6377bf774a23a6762c877f
Author: Michael Jumper <[email protected]>
Date: 2017-06-08T18:20:10Z
GUACAMOLE-346: Avoid blocking the main thread when seeking within a session
recording.
commit 744574d026d9077e8cf36a838c3f47e55e787b42
Author: Michael Jumper <[email protected]>
Date: 2017-07-15T23:06:32Z
GUACAMOLE-346: Always replay frames asynchronously when seeking.
commit b325eb8139f82387e8a4efbe8c2449b60066b142
Author: Michael Jumper <[email protected]>
Date: 2017-07-15T23:10:28Z
GUACAMOLE-346: Require seek callback internally, for sake of simplicity.
commit 23cf840ba6935434752a3160de07206a012e6a25
Author: Michael Jumper <[email protected]>
Date: 2017-07-15T23:12:21Z
GUACAMOLE-346: Playback must take into account that seeking is asynchronous.
commit 21eadec6a459d6dec192ccea2a00ea3b600e735a
Author: Michael Jumper <[email protected]>
Date: 2017-07-15T23:15:01Z
GUACAMOLE-346: Seek operations should be atomic with respect to the various
timeouts.
commit b41311f1ed9567cfe0201571ae8cb96ba2414b99
Author: Michael Jumper <[email protected]>
Date: 2017-07-15T23:16:26Z
GUACAMOLE-346: Simplify style of seek callback invocation.
commit 25de43391aebb6a042fcc2ba2755e7fe081a8187
Author: Michael Jumper <[email protected]>
Date: 2017-07-15T23:50:02Z
GUACAMOLE-346: Display "seek in progress" notification when seeking in
playback example.
commit ed3c022f7e437bfad62ca3b4bd7286521e348a5f
Author: Michael Jumper <[email protected]>
Date: 2017-07-15T23:58:39Z
GUACAMOLE-346: Provide explicit "cancel" button for in-progress seek.
commit 519daeebe206f338606ba73d89c8b6c287b6fc29
Author: Michael Jumper <[email protected]>
Date: 2017-07-16T00:10:47Z
GUACAMOLE-346: Use internal seekToFrame() to handle frame timing.
commit be9124d599ef28b75736b34eed6221f0844a48b6
Author: Michael Jumper <[email protected]>
Date: 2017-07-16T00:25:34Z
GUACAMOLE-346: Update seeking state when paused or canceled.
commit 768974711caddebbf8ef432da3e6bc575db35408
Author: Michael Jumper <[email protected]>
Date: 2017-07-16T00:32:03Z
GUACAMOLE-346: Add "paused" notification to example player.
commit 387302db4821210839aabef42d23869ff203bd93
Author: Michael Jumper <[email protected]>
Date: 2017-07-16T00:41:58Z
GUACAMOLE-346: Simply resume playback if seek operation is canceled.
commit 929452e7015896efb20ec77f2250279db02747df
Author: Michael Jumper <[email protected]>
Date: 2017-07-16T00:45:39Z
GUACAMOLE-346: Remove "paused" notification. Correct UI behavior.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
