Github user mike-jumper commented on a diff in the pull request:
https://github.com/apache/incubator-guacamole-client/pull/176#discussion_r128306318
--- Diff: doc/guacamole-playback-example/src/main/webapp/index.html ---
@@ -28,10 +28,19 @@
<body>
<!-- Guacamole recording player -->
- <div class="player">
+ <div id="player">
--- End diff --
Eh ... now that the example is referring to the player as a single,
distinct object within the JS, that would require doing something like
`getElementsByClassName('player')[0]`, which is semantically wrong.
It might make sense to apply the player functionality as a behavior to
absolutely all elements having the "player" class, but that would make the
example overly complex IMHO.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
