On Tuesday, August 1, 2017, 11:18:24 AM EDT, Or Cohen <[email protected]> wrote:
> Should I open a JIRA issue first?
If you have a fix to contribute, yes, the first step is opening a JIRA issue,
then forking the github repo, making your change, and opening a pull request
where you tag the PR and your commits with the JIRA instance (GUACAMOLE-XXX:).
As far as whether this behavior is intentional or not, Mike or James would
probably have to speak to that; however, my question would be this: Are there
any consequences to the current Guacamole Client code by making this change?
It looks like you've made a custom application leveraging the guacamole common
code - I'd suggest taking the full Guacamole Client code, making your proposed
change, and making sure that it still behaves the way it is expected to when
the tunnel disconnects. If I understand the situation you're referring to, in
the Guacamole Client code this would mean that a notification box is displayed
that the tunnel connection has been lost, and the user is given an option to go
home or Reconnect. If your change causes this notification to not be displayed
because the client continually retries the connection, then the "fix" may not
end up included in the main Guacamole code. If it doesn't impact that and have
other adverse impacts, then it may end up getting merged.
If it doesn't get merged, you could still maintain the fork of the Apache
version of the code in your own repo, modify it to your needs, and use it.
Maintaining the fork would also allow you to continue to merge in changes and
improvements from the upstream repos as those happen.
Regards,Nick
