On Tue, Aug 1, 2017 at 6:46 PM, Nick Couchman < [email protected]> wrote:
> > > > > On Tuesday, August 1, 2017, 11:18:24 AM EDT, Or Cohen <[email protected]> > wrote: > > > Should I open a JIRA issue first? > > If your change causes this notification to not be displayed because the > client continually retries the connection, then the "fix" may not end up > included in the main Guacamole code. If it doesn't impact that and have > other adverse impacts, then it may end up getting merged. > If it doesn't get merged, you could still maintain the fork of the Apache > version of the code in your own repo, modify it to your needs, and use it. > Maintaining the fork would also allow you to continue to merge in changes > and improvements from the upstream repos as those happen. > Of course, I intend to fully try the code to make sure it doesn't break anything. I have the Guacamole application as a reference implementation. Knowing (a bit) the Guacamole application, it does reconnect after a timeout (and offers a manual reconnect) and contiously so. I see that guacClientManager angular service (and the reconnect button) actually replaces (disonnects, deletes and reconnects) the entire client. Now, I suspect that this is intentional and maybe that's why the Tunnel's state behavior doesn't really affect it. Perhaps the client can't handle a reconnect properly? I'll submit a PR. Worst case, it is intentional and won't get accepted :)
