There are a couple of pull requests that have stalled with no response from the original author. Okay, I have one myself that I need to go back and finish up, but I'm more concerned about a couple of them that fix bugs or other undesirable behavior.
Before I go over the individual issues, Mike, I'm curious how you managed to get client PR 174 to close when the merge was completed for PR 193 - it's almost as if the reference in GitHub triggered the close automatically? Is there anything special you had to do? This could be useful if we're going to try to merge in some of the stalled PRs and get them to close without involving the ASF Infra team and asking them specifically to close them. Anyway, here are the ones that I think should be pushed through and where the original authors seem to be unresponsive... https://github.com/apache/incubator-guacamole-client/pull/129 - GUACAMOLE-243, related to LDAP referrals. I'm afraid I may be at least partially responsible for not encouraging alt36 to be more involved, but I've pinged on it several times and gotten no response. At least alt36's changes, plus some additional changes to make referrals configurable, would be really good to have the LDAP authentication code. https://github.com/apache/incubator-guacamole-client/pull/175 - GUACAMOLE-350, allowing SSH keys beyond 2048 bits. The SSH keys I routinely use are at least 4096, so this change is near and dear to my day-to-day usage. Alexandre got this one almost to completion and seems to have dropped it or run out of time. There are a couple of others that probably just need to be closed by Infra, but those two I think would benefit the code to have the PRs finished up and merged in. Any discussion about how we want to handle these? I know we need to maintain credit and encourage participation, etc., but at some point does it make sense to take what has been started and push it through with the changes that are needed to get it to a merge-able place? -Nick
