On Tue, Oct 17, 2017 at 5:43 AM, Nick Couchman <[email protected]> wrote: >> >> Alright, then. Guess there's nothing to do now but close the pull requests. >> If it's possible to use ASF's deployment of Git Box (I don't know what's >> required here), then we can do this ourselves. Otherwise, might need to >> open a ticket with infra. >> >> - Mike >> > I'll look into Gitbox and see what I can figure out there. > > The other option is to fork their changes (so as to maintain their > contributions), finish things up, and then use the magic "this closes #XXX" > that you did on that other PR. Is there any reason not to go that route? >
My blunt opinion would be that we should never take over changes. The point of an open source community like Apache Guacamole is collaboration. There's a big difference between a contribution from a contributor who is working together with the existing development community for the benefit of all, vs. abandoned code in a basket on the project's doorstep. The latter is essentially a contribution of technical debt, and ultimately harmful if accepted in that form. We should definitely give all contributors the benefit of the doubt here, and there's no reason to assume that they intended to abandon the changes, but closing stalled PR's is not a bad thing. Just as with a JIRA issue where the reporter has ceased responding, closing things just acknowledges that the issue is not moving forward, and allows the community to refocus on other matters. If the contributor comes back, then things can be reopened. If not, then there really is no contribution, and we should just move forward as we normally would. - Mike
