Github user mike-jumper commented on a diff in the pull request:
https://github.com/apache/incubator-guacamole-server/pull/109#discussion_r143347204
--- Diff: src/protocols/vnc/user.c ---
@@ -112,6 +112,9 @@ int guac_vnc_user_leave_handler(guac_user* user) {
guac_vnc_client* vnc_client = (guac_vnc_client*) user->client->data;
+ if (!vnc_client || !user || !vnc_client->display ||
!vnc_client->display->cursor)
--- End diff --
Summarizing [my comment from
earlier](https://github.com/apache/incubator-guacamole-server/pull/109#issuecomment-331722195),
this check seems overly broad, and it's unlikely that all of these pointers
need to be verified. We shouldn't be paranoidly checking for `NULL` every time
we're about to use a pointer.
If we're going to add checks, the reason for each check should be known,
and the cause of
[GUACAMOLE-388](https://issues.apache.org/jira/browse/GUACAMOLE-388) needs to
be determined.
---
