Github user chipitsine commented on a diff in the pull request:
https://github.com/apache/incubator-guacamole-server/pull/109#discussion_r143347769
--- Diff: src/protocols/vnc/user.c ---
@@ -112,6 +112,9 @@ int guac_vnc_user_leave_handler(guac_user* user) {
guac_vnc_client* vnc_client = (guac_vnc_client*) user->client->data;
+ if (!vnc_client || !user || !vnc_client->display ||
!vnc_client->display->cursor)
--- End diff --
hello, I'm doing this in my spare time.
I do not mind if you want to determine the root cause of GUACAMOLE-388
what I wanted to do is to add check for null, it still makes sense, i.e.
"check for null before dereferencing the pointer". it will help if something
will change later on the caller side.
as for "overly broad", I'll make it more narrow soon
---
