Github user necouchman commented on a diff in the pull request:
https://github.com/apache/incubator-guacamole-client/pull/197#discussion_r145992717
--- Diff:
guacamole-ext/src/main/java/org/apache/guacamole/net/event/AuthenticationSuccessEvent.java
---
@@ -43,19 +44,19 @@
/**
* The credentials which passed authentication.
*/
- private Credentials credentials;
+ private AuthenticatedUser authenticatedUser;
/**
* Creates a new AuthenticationSuccessEvent which represents a
successful
* authentication attempt with the given credentials.
*
* @param context The UserContext created as a result of successful
* authentication.
- * @param credentials The credentials which passed authentication.
+ * @param authenticatedUser The user which passed authentication.
*/
- public AuthenticationSuccessEvent(UserContext context, Credentials
credentials) {
+ public AuthenticationSuccessEvent(UserContext context,
AuthenticatedUser authenticatedUser) {
--- End diff --
Is there an expectation that this getUserContext() method in the event
handler will get called repeatedly?
I can revert back to the original method of storing it there - but, if we
do that, we have to handle the exception that happens when it is null. I'm
happy to put back my code for just logging the exception and not passing it
through in this instance, if that's okay, or I'm happy to investigate other
routes if those are preferred?
---
