Github user necouchman commented on a diff in the pull request:
https://github.com/apache/incubator-guacamole-client/pull/197#discussion_r146261874
--- Diff:
guacamole-ext/src/main/java/org/apache/guacamole/net/event/AuthenticationSuccessEvent.java
---
@@ -43,19 +44,19 @@
/**
* The credentials which passed authentication.
*/
- private Credentials credentials;
+ private AuthenticatedUser authenticatedUser;
/**
* Creates a new AuthenticationSuccessEvent which represents a
successful
* authentication attempt with the given credentials.
*
* @param context The UserContext created as a result of successful
* authentication.
- * @param credentials The credentials which passed authentication.
+ * @param authenticatedUser The user which passed authentication.
*/
- public AuthenticationSuccessEvent(UserContext context, Credentials
credentials) {
+ public AuthenticationSuccessEvent(UserContext context,
AuthenticatedUser authenticatedUser) {
--- End diff --
Okay, reverted to having the objects in here, but took a slightly different
angle on it by having the `AuthenticationSuccessEvent` constructor handle
pulling all of the objects out of the `AuthenticatedUser` object, and handled
catching the `GuacamoleResourceNotFoundException` exception there, instead of
in `AuthenticationService`. Let me know if this looks okay, or if it should go
back to the way I originally had it, catching the error in
`AuthenticationService`, instead. Or if there's some other way that it needs
to be done?
---
