Github user mike-jumper commented on a diff in the pull request:
https://github.com/apache/incubator-guacamole-client/pull/202#discussion_r149184513
--- Diff:
extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/user/UserService.java
---
@@ -267,8 +285,23 @@ private String generateLDAPQuery(String username)
// Add all DNs for found users
while (results.hasMore()) {
- LDAPEntry entry = results.next();
- userDNs.add(entry.getDN());
+ try {
+ LDAPEntry entry = results.next();
+ userDNs.add(entry.getDN());
+ }
+
+ // Deal with errors following referrals
+ catch (LDAPReferralException e) {
+ if (confService.getFollowReferrals()) {
+ logger.error("Error trying to follow a referral.",
e.getMessage());
+ logger.debug("Encountered an error trying to
follow a referral.", e);
+ throw new GuacamoleServerException("Failed while
trying to follow referrals.", e);
+ }
+ else {
+ logger.warn("Given a referral, not following it.",
e.getMessage());
--- End diff --
Missing `{}` in log message.
---
