[
https://issues.apache.org/jira/browse/HAMA-699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13805318#comment-13805318
]
ChiaHung Lin commented on HAMA-699:
-----------------------------------
+1 for the patch.
The patch passes against the current svn r1532340, including compilation and
unit test.
Thanks for the explanation.
So it's a naming issue from my viewpoint. We don't need to move
PartitioningRunner, etc. to commons module (o.a.h.c.io) right now (at the
moment most of classes are located at bsp package including
PartitioningRunner.java in svn and 0.6.3). Only relocating files under writable
package
{code}
org.apache.hama.commons.io.writable.DenseVectorWritable.java
org.apache.hama.commons.io.writable.MatrixWritable.java
org.apache.hama.commons.io.writable.SparseVectorWritable.java
org.apache.hama.commons.io.writable.StringArrayWritable.java
org.apache.hama.commons.io.writable.TextArrayWritable.java
org.apache.hama.commons.io.writable.VectorWritable.java
{code}
to o.a.h.c.io won't create dep from commons to core.
But anyway that's not the main issue here. Simply thought that we don't need to
move those classes again if needed.
> Add commons module
> ------------------
>
> Key: HAMA-699
> URL: https://issues.apache.org/jira/browse/HAMA-699
> Project: Hama
> Issue Type: Improvement
> Reporter: Edward J. Yoon
> Assignee: Martin Illecker
> Fix For: 0.7.0
>
> Attachments: commons-module.txt, HAMA-699.patch
>
>
> As we disscussed, I'd like to add commons module.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
