[ 
https://issues.apache.org/jira/browse/HAMA-699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13809310#comment-13809310
 ] 

ChiaHung Lin commented on HAMA-699:
-----------------------------------

Moving KeyValuePair, etc. to commons looks ok because applying the 
HAMA-699_3.patch against current HEAD (r1532340) passes compilation and unit 
tests. Also checking the pom.xml, it doesn't create cyclic dep issue. Packages 
ml, graph, and example depend on core and commons, but not vice versa. That 
looks good. 




> Add commons module
> ------------------
>
>                 Key: HAMA-699
>                 URL: https://issues.apache.org/jira/browse/HAMA-699
>             Project: Hama
>          Issue Type: Improvement
>            Reporter: Edward J. Yoon
>             Fix For: 0.7.0
>
>         Attachments: commons-module.txt, HAMA-699_3.patch, HAMA-699.patch
>
>
> As we disscussed, I'd like to add commons module.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Reply via email to