@PJ Fanning <[email protected]> Sorry missed addressing your comments:
General > * In vote email, link to the release notes and contributor details, > don’t embed them in the email > Ack. > * Why do we need 2 whl files and sf_hamilton-1.89.0.tar.gz in the > release distro? The contents seem very similar in all 3. Would it be > possible to reduce the files that need to be reviewed? My understanding was that to also publish to pypi as sf_hamilton we should have separate artifacts. They should be identical, other than some naming. We could do less if we could post-process the apache one. Would that be acceptable? Source Release > * License lists file that doesn’t exist > - contrib/hamilton/contrib/user/skrawcz/customize_embeddings/__init__.py * Some files missing Apache headers - in hamilton/dataflows/template > and some .md files I've addressed these in a PR. whl files > * Similar license issues and header issues to source release > * Missing DISCLAIMER in sf_hamilton-1.89.0.dist-info/licenses/ yep this should be the same contents. I'll look into the DISCLAIMER missing and address that. Otherwise I just called the result on this vote. Anything else to do before going to the main mailing list? It's late here so wont finish that email tonight. Thanks for your help! Cheers, Stefan On Tue, Sep 30, 2025 at 10:34 AM PJ Fanning <[email protected]> wrote: > It doesn't invalidate this vote but the expectation is that people > voting fill in the checklist by adding 'x' in the checks that you did. > > Checklist for reference: > [ ] Download links are valid. > [ ] Checksums and signatures. > [ ] LICENSE/NOTICE files exist > [ ] No unexpected binary files > [ ] All source files have ASF headers > [ ] Can use from source > > On Tue, 30 Sept 2025 at 18:11, Ryan Whitten <[email protected]> > wrote: > > > > +1 from me > > > > > On Sep 30, 2025, at 9:00 AM, PJ Fanning <[email protected]> wrote: > > > > > > There is no formal concept of votes being 'binding' in a PPMC vote. In > > > PMC votes, votes are usually explicitly said to be binding or > > > non-binding to help the person enumerating the vote. They are still > > > expected to double check if everyone who said 'binding' is entitled to > > > make a 'binding' vote (ie. a PMC member). > > > For the Hamilton PPMC vote, we need at least 3 PPMC members (including > > > mentors) to approve the release and there to be more total +1s than > > > -1s. Then we need the Incubator PMC to vote on the release before it > > > can proceed. I am an Incubator PMC member so my +1 is binding in their > > > vote. > > > > > > On Tue, 30 Sept 2025 at 13:45, Charles Swartz > > > <[email protected]> wrote: > > >> > > >> +1 binding ... just in case it is more than a formality > > >> -- > > >> *Charles W. Swartz VI, Ph.D.* > > >> Senior Operations Research Analyst > > >> Email: [email protected] > > >> Cell: 1-215-479-3249 > > >> > > >> > > >> On Tue, Sep 30, 2025 at 2:06 AM Stefan Krawczyk < > [email protected]> > > >> wrote: > > >> > > >>> Thanks @Elijah and @Charles, but I think for vote purposes since > you're > > >>> part of the PMC you need to add "binding" to your votes, right PJ? > (or is > > >>> that a mere formality?) > > >>> > > >>> On Mon, Sep 29, 2025 at 6:48 PM Charles Swartz < > > >>> [email protected]> wrote: > > >>> > > >>>> +1 Nice work Stefan! > > >>>> > > >>>> Note: I have been using a local-built version of 1.89.0 for the > last week > > >>>> or so - no issues. > > >>>> > > >>>> > > >>>> -- > > >>>> Charles W. Swartz VI, Ph.D. > > >>>> Senior Operations Research Analyst > > >>>> Email: [email protected] > > >>>> Cell: 1-215-479-3249 > > >>>> > > >>>> ________________________________ > > >>>> From: Stefan Krawczyk <[email protected]> > > >>>> Sent: Sunday, September 28, 2025 11:50 PM > > >>>> To: [email protected] <[email protected]> > > >>>> Subject: [VOTE] Release Apache hamilton 1.89.0-incubating (release > > >>>> candidate 1) > > >>>> > > >>>> Hi all, > > >>>> > > >>>> I think we're almost there! > > >>>> > > >>>> This is a call for a vote on releasing Apache hamilton > 1.89.0-incubating, > > >>>> release candidate 1. Note, after this vote, we'll move this to the > > >>>> incubator mailing list for another vote. > > >>>> > > >>>> This release includes the following changes: > > >>>> > > >>>> ## What's Changed > > >>>> * Fix local (Windows) tests by @cswartzvi in > > >>>> https://github.com/apache/hamilton/pull/1302 > > >>>> * Wires through REACT_APP_HAMILTON_SUB_PATH for docker by @skrawcz > in > > >>>> https://github.com/apache/hamilton/pull/1301 > > >>>> * Fix `dlt` plugin with changes to `loader_file_format` by > @cswartzvi > > >>>> in https://github.com/apache/hamilton/pull/1306 > > >>>> * Update SECURITY.md by @pjfanning in > > >>>> https://github.com/apache/hamilton/pull/1315 > > >>>> * Delete CODE_OF_CONDUCT.md by @pjfanning in > > >>>> https://github.com/apache/hamilton/pull/1316 > > >>>> * Create .asf.yaml by @pjfanning in > > >>>> https://github.com/apache/hamilton/pull/1312 > > >>>> * Changes license to apache 2.0 by @skrawcz in > > >>>> https://github.com/apache/hamilton/pull/1335 > > >>>> * Adds website publishing by @skrawcz in > > >>>> https://github.com/apache/hamilton/pull/1344 > > >>>> * try publish changes in .asf.yaml by @pjfanning in > > >>>> https://github.com/apache/hamilton/pull/1345 > > >>>> * Migrate to GitHub acitions by @jernejfrank in > > >>>> https://github.com/apache/hamilton/pull/1342 > > >>>> * Add new function modifier `upack_fields` by @cswartzvi in > > >>>> https://github.com/apache/hamilton/pull/1303 > > >>>> * Replaces most links and Hamilton references by @skrawcz in > > >>>> https://github.com/apache/hamilton/pull/1339 > > >>>> * add proper license by @pjfanning in > > >>>> https://github.com/apache/hamilton/pull/1354 > > >>>> * Serialize NaN and Infinity values as strings for Hamilton UI by > > >>>> @Phrogz in https://github.com/apache/hamilton/pull/1322 > > >>>> * Update extract fields by @cswartzvi in > > >>>> https://github.com/apache/hamilton/pull/1305 > > >>>> * Adds incubator logo and ASF info for #1346 by @skrawcz in > > >>>> https://github.com/apache/hamilton/pull/1353 > > >>>> * Deletes RayWorkflows by @skrawcz in > > >>>> https://github.com/apache/hamilton/pull/1359 > > >>>> * remove DAGWorks license by @pjfanning in > > >>>> https://github.com/apache/hamilton/pull/1367 > > >>>> * add license headers to source files #1360 by @Gophersen in > > >>>> https://github.com/apache/hamilton/pull/1369 > > >>>> * add MIT LIcense due to experimental/databackend.py by @pjfanning > in > > >>>> https://github.com/apache/hamilton/pull/1361 > > >>>> * Fix typos and minor formatting issues in documentation by > > >>>> @datashaman in https://github.com/apache/hamilton/pull/1373 > > >>>> * Clean up repo for first ASF release (Attempt 2) by @cswartzvi in > > >>>> https://github.com/apache/hamilton/pull/1374 > > >>>> * Adds missing license headers by @skrawcz in > > >>>> https://github.com/apache/hamilton/pull/1379 > > >>>> * Adds header to __init__.py files by @skrawcz in > > >>>> https://github.com/apache/hamilton/pull/1382 > > >>>> * Add missing headers and update files to help with release by > > >>>> @skrawcz in https://github.com/apache/hamilton/pull/1378 > > >>>> * Adds flit to build project by @skrawcz in > > >>>> https://github.com/apache/hamilton/pull/1387 > > >>>> > > >>>> > > >>>> ## New Contributors > > >>>> * @pjfanning made their first contribution in > > >>>> https://github.com/apache/hamilton/pull/1315 > > >>>> * @Phrogz made their first contribution in > > >>>> https://github.com/apache/hamilton/pull/1322 > > >>>> * @Gophersen made their first contribution in > > >>>> https://github.com/apache/hamilton/pull/1369 > > >>>> * @datashaman made their first contribution in > > >>>> https://github.com/apache/hamilton/pull/1373 > > >>>> > > >>>> > > >>>> The artifacts for this release candidate can be found at: > > >>>> > https://dist.apache.org/repos/dist/dev/incubator/hamilton/1.89.0-RC1 > > >>>> > > >>>> The Git tag to be voted upon is: v1.89.0-incubating-RC1. > > >>>> > > >>>> The release hash is: > > >>>> > > >>>> b50355e5bacd3ba746f80072fe6c83a786f44b0a - this just adds the > verison > > >>> bump > > >>>> (not on master) - and is what the tag refers to. > > >>>> > > >>>> > > >>>> b2bee61b7c63af9c44114384710cd2e0efecffca -this is the functional > commit > > >>>> reference. > > >>>> > > >>>> Release artifacts are signed with the following key: > > >>>> > > >>>> FE668E857E89A11C5E5C000CA8D3D15600545C61 > > >>>> > > >>>> The KEYS file is available at: > > >>>> https://downloads.apache.org/incubator/hamilton/KEYS > > >>>> > > >>>> Note: I added a new key, since I was trying out the setup_keys.sh. > > >>>> > > >>>> *Please download, verify, and test the release candidate.* > > >>>> > > >>>> *For testing*, please run some of the examples, scripts/qualify.sh > > >>>> <https://github.com/apache/hamilton/blob/main/scripts/qualify.sh > >has > > >>>> a sampling of them to run. Note: you'll likely want to install the > > >>> optional > > >>>> dependencies selectively, or just go ahead and install everything > > >>> required > > >>>> for test. > > >>>> Also if an example doesn't work, double check the README for set up > > >>>> instructions. > > >>>> > > >>>> The vote will run for a minimum of 72 hours. > > >>>> > > >>>> Please vote: > > >>>> > > >>>> [ ] +1 Release this package as Apache hamilton 1.89.0-incubating > > >>>> [ ] +0 No opinion > > >>>> [ ] -1 Do not release this package because... (Please provide a > reason) > > >>>> > > >>>> Checklist for reference: > > >>>> [ ] Download links are valid. > > >>>> [ ] Checksums and signatures. > > >>>> [ ] LICENSE/NOTICE files exist > > >>>> [ ] No unexpected binary files > > >>>> [ ] All source files have ASF headers > > >>>> [ ] Can use from source > > >>>> > > >>>> On behalf of the Apache hamilton PPMC, > > >>>> > > >>>> Stefan > > >>>> > > >>>> Note: this email and build is based on the release helper script > > >>>> < > > >>>> > > >>> > https://github.com/apache/hamilton/blob/main/scripts/apache_release_helper.py > > >>>>> > > >>>> we are curating. > > >>>> > > >>> > > >
