+1 binding but there are a few issues that we could address for future RCs [x] Download links are valid. [x] Checksums and signatures. [x] LICENSE/NOTICE/DISCLAIMER files exist [x] No unexpected binary files [ ] All source files have ASF headers -- most do [ ] Can use from source
General * In vote email, link to the release notes and contributor details, don’t embed them in the email * Why do we need 2 whl files and sf_hamilton-1.89.0.tar.gz in the release distro? The contents seem very similar in all 3. Would it be possible to reduce the files that need to be reviewed? Source Release * License lists file that doesn’t exist - contrib/hamilton/contrib/user/skrawcz/customize_embeddings/__init__.py * Some files missing Apache headers - in hamilton/dataflows/template and some .md files whl files * Similar license issues and header issues to source release * Missing DISCLAIMER in sf_hamilton-1.89.0.dist-info/licenses/ On Mon, 29 Sept 2025 at 04:52, Stefan Krawczyk <[email protected]> wrote: > > Hi all, > > I think we're almost there! > > This is a call for a vote on releasing Apache hamilton 1.89.0-incubating, > release candidate 1. Note, after this vote, we'll move this to the > incubator mailing list for another vote. > > This release includes the following changes: > > ## What's Changed > * Fix local (Windows) tests by @cswartzvi in > https://github.com/apache/hamilton/pull/1302 > * Wires through REACT_APP_HAMILTON_SUB_PATH for docker by @skrawcz in > https://github.com/apache/hamilton/pull/1301 > * Fix `dlt` plugin with changes to `loader_file_format` by @cswartzvi > in https://github.com/apache/hamilton/pull/1306 > * Update SECURITY.md by @pjfanning in > https://github.com/apache/hamilton/pull/1315 > * Delete CODE_OF_CONDUCT.md by @pjfanning in > https://github.com/apache/hamilton/pull/1316 > * Create .asf.yaml by @pjfanning in > https://github.com/apache/hamilton/pull/1312 > * Changes license to apache 2.0 by @skrawcz in > https://github.com/apache/hamilton/pull/1335 > * Adds website publishing by @skrawcz in > https://github.com/apache/hamilton/pull/1344 > * try publish changes in .asf.yaml by @pjfanning in > https://github.com/apache/hamilton/pull/1345 > * Migrate to GitHub acitions by @jernejfrank in > https://github.com/apache/hamilton/pull/1342 > * Add new function modifier `upack_fields` by @cswartzvi in > https://github.com/apache/hamilton/pull/1303 > * Replaces most links and Hamilton references by @skrawcz in > https://github.com/apache/hamilton/pull/1339 > * add proper license by @pjfanning in > https://github.com/apache/hamilton/pull/1354 > * Serialize NaN and Infinity values as strings for Hamilton UI by > @Phrogz in https://github.com/apache/hamilton/pull/1322 > * Update extract fields by @cswartzvi in > https://github.com/apache/hamilton/pull/1305 > * Adds incubator logo and ASF info for #1346 by @skrawcz in > https://github.com/apache/hamilton/pull/1353 > * Deletes RayWorkflows by @skrawcz in > https://github.com/apache/hamilton/pull/1359 > * remove DAGWorks license by @pjfanning in > https://github.com/apache/hamilton/pull/1367 > * add license headers to source files #1360 by @Gophersen in > https://github.com/apache/hamilton/pull/1369 > * add MIT LIcense due to experimental/databackend.py by @pjfanning in > https://github.com/apache/hamilton/pull/1361 > * Fix typos and minor formatting issues in documentation by > @datashaman in https://github.com/apache/hamilton/pull/1373 > * Clean up repo for first ASF release (Attempt 2) by @cswartzvi in > https://github.com/apache/hamilton/pull/1374 > * Adds missing license headers by @skrawcz in > https://github.com/apache/hamilton/pull/1379 > * Adds header to __init__.py files by @skrawcz in > https://github.com/apache/hamilton/pull/1382 > * Add missing headers and update files to help with release by > @skrawcz in https://github.com/apache/hamilton/pull/1378 > * Adds flit to build project by @skrawcz in > https://github.com/apache/hamilton/pull/1387 > > > ## New Contributors > * @pjfanning made their first contribution in > https://github.com/apache/hamilton/pull/1315 > * @Phrogz made their first contribution in > https://github.com/apache/hamilton/pull/1322 > * @Gophersen made their first contribution in > https://github.com/apache/hamilton/pull/1369 > * @datashaman made their first contribution in > https://github.com/apache/hamilton/pull/1373 > > > The artifacts for this release candidate can be found at: > https://dist.apache.org/repos/dist/dev/incubator/hamilton/1.89.0-RC1 > > The Git tag to be voted upon is: v1.89.0-incubating-RC1. > > The release hash is: > > b50355e5bacd3ba746f80072fe6c83a786f44b0a - this just adds the verison bump > (not on master) - and is what the tag refers to. > > > b2bee61b7c63af9c44114384710cd2e0efecffca -this is the functional commit > reference. > > Release artifacts are signed with the following key: > > FE668E857E89A11C5E5C000CA8D3D15600545C61 > > The KEYS file is available at: > https://downloads.apache.org/incubator/hamilton/KEYS > > Note: I added a new key, since I was trying out the setup_keys.sh. > > *Please download, verify, and test the release candidate.* > > *For testing*, please run some of the examples, scripts/qualify.sh > <https://github.com/apache/hamilton/blob/main/scripts/qualify.sh>has > a sampling of them to run. Note: you'll likely want to install the optional > dependencies selectively, or just go ahead and install everything required > for test. > Also if an example doesn't work, double check the README for set up > instructions. > > The vote will run for a minimum of 72 hours. > > Please vote: > > [ ] +1 Release this package as Apache hamilton 1.89.0-incubating > [ ] +0 No opinion > [ ] -1 Do not release this package because... (Please provide a reason) > > Checklist for reference: > [ ] Download links are valid. > [ ] Checksums and signatures. > [ ] LICENSE/NOTICE files exist > [ ] No unexpected binary files > [ ] All source files have ASF headers > [ ] Can use from source > > On behalf of the Apache hamilton PPMC, > > Stefan > > Note: this email and build is based on the release helper script > <https://github.com/apache/hamilton/blob/main/scripts/apache_release_helper.py> > we are curating.
