[added d...@] Egor, Thanks for asking for review. I miss code exercises. The code looks ok. BTW, the review took me here [1] - thanks Google for the wonderful instrument.
As for your last question, TI appeared in java earlier than java.lang.instrument. This means implementing the latter using the former may make some sense. [1] http://www.google.com/codesearch/p?hl=ru#TasP9sO-cIM/trunk/vm/vmcore/src/jvmti/jvmti.cpp&q=load_agentlib&exact_package=http://svn.apache.org/repos/asf/harmony/enhanced/drlvm/ On Tue, Dec 15, 2009 at 3:03 PM, Egor Pasko <egor.pa...@gmail.com> wrote: > Alexey, can you, please, review this patch? > > issue: https://issues.apache.org/jira/browse/HARMONY-6399 > > > I really like the idea of enabling -javaagent, but I am not sure that > it should go through TI ... > > -- > Egor Pasko > -- With best regards / с наилучшими пожеланиями, Alexei Fedotov / Алексей Федотов, http://www.telecom-express.ru/ http://harmony.apache.org/ http://www.expressaas.com/ http://openmeetings.googlecode.com/
