Thanks Hong, To be clear,
The original patch is: commit 497ae5db996094150e475659e06eea929e209841 Author: Paul Guo <[email protected]> Date: Thu Jun 30 18:34:27 2016 +0800 HAWQ-867. Replace the git-submobule mechanism with git-clone Following further patch is trivial, commit 3ba7d8ef4b27b11bec02beefe0dd037698687175 Author: Paul Guo <[email protected]> Date: Tue Jul 5 18:16:17 2016 +0800 HAWQ-888. Remove some dummy files which were used to keep related "empty" directories. 2016-07-08 10:10 GMT+08:00 Hong Wu <[email protected]>: > Hi roman, > > I found his related pull requests for this thread and listed below, > > https://github.com/apache/incubator-hawq/pull/773 > https://github.com/apache/incubator-hawq/pull/771 > https://github.com/apache/incubator-hawq/pull/762 > > All of above pull requests have been merged into master because these block > the latest release in github. welcome further comments, thanks. > > Best > xunzhang > > 2016-07-08 2:04 GMT+08:00 Roman Shaposhnik <[email protected]>: > > > On Thu, Jul 7, 2016 at 3:20 AM, Paul Guo <[email protected]> wrote: > > > For gporca it is ok to pre-build them and pass orca installation path > to > > > hawq, but for > > > pgcrypto and plr, having a script to run before building hawq seems to > > not > > > be a good > > > idea, technically speaking. > > > > > > plr/pgcrypto depends on the configure options and configure checking. > > > (e.g. with and without openssl option in configure, pgcrypto build > > results > > > will be different). > > > > > > That means building of these features are not 100% independent on > > building > > > of hawq. > > > > The above makes sense, but there's way too many ways to interpret the > > particulars of it. Before we move ahead, how about I take a look at the > > branch that is being cut (see the other thread) and provide you more > > technical feedback? > > > > Thanks, > > Roman. > > >
