> On 2010-06-11 09:59:29, stack wrote: > > src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java, line 1439 > > <http://review.hbase.org/r/167/diff/1/?file=1237#file1237line1439> > > > > Should this be public? Isn't it just used internally? > > Todd Lipcon wrote: > good call, will make it package private
Actually, all the other put methods are also public, even though HRegion itself is basically internal to the RS - Todd ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://review.hbase.org/r/167/#review181 ----------------------------------------------------------- On 2010-06-11 00:50:05, Todd Lipcon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://review.hbase.org/r/167/ > ----------------------------------------------------------- > > (Updated 2010-06-11 00:50:05) > > > Review request for hbase, Kannan Muthukkaruppan and Ryan Rawson. > > > Summary > ------- > > I implemented the "mini batching" idea we talked about on the JIRA. > > This currently breaks some of the error handling, so I dont intend to commit > as is, but everyone is busy so wanted to put a review up now while I tidy up > the rest. > > > This addresses bug HBASE-2353. > http://issues.apache.org/jira/browse/HBASE-2353 > > > Diffs > ----- > > src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java 6b6d098 > src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java > a1baff4 > src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLog.java 034690e > > Diff: http://review.hbase.org/r/167/diff > > > Testing > ------- > > Some PEs on a real sync-enabled cluster, seems faster but haven't done > scientific benchmarking. > > > Thanks, > > Todd > >
