----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://review.hbase.org/r/167/#review204 -----------------------------------------------------------
generally looks interesting and sound. This may need to be reconciled with http://review.hbase.org/r/151/ - batch operations for put/delete/get. - Ryan On 2010-06-11 15:18:10, Todd Lipcon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://review.hbase.org/r/167/ > ----------------------------------------------------------- > > (Updated 2010-06-11 15:18:10) > > > Review request for hbase, Kannan Muthukkaruppan and Ryan Rawson. > > > Summary > ------- > > I implemented the "mini batching" idea we talked about on the JIRA. > > This currently breaks some of the error handling, so I dont intend to commit > as is, but everyone is busy so wanted to put a review up now while I tidy up > the rest. > > > This addresses bug HBASE-2353. > http://issues.apache.org/jira/browse/HBASE-2353 > > > Diffs > ----- > > src/main/java/org/apache/hadoop/hbase/HConstants.java 1e59533 > src/main/java/org/apache/hadoop/hbase/ipc/HRegionInterface.java 62617ac > src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java adc505b > src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java > 541ec9b > src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLog.java ba04820 > src/test/java/org/apache/hadoop/hbase/MultithreadedTestUtil.java 870f925 > src/test/java/org/apache/hadoop/hbase/TestAcidGuarantees.java 8a5206c > src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java e75767d > > Diff: http://review.hbase.org/r/167/diff > > > Testing > ------- > > Some PEs on a real sync-enabled cluster, seems faster but haven't done > scientific benchmarking. > > > Thanks, > > Todd > >
