----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://review.hbase.org/r/170/#review193 -----------------------------------------------------------
Ship it! looks good to me - Jonathan On 2010-06-11 12:14:26, Jean-Daniel Cryans wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://review.hbase.org/r/170/ > ----------------------------------------------------------- > > (Updated 2010-06-11 12:14:26) > > > Review request for hbase. > > > Summary > ------- > > Patch against branch that does some refactoring and that fixes the bug at the > same time. Adds a unit test that doesn't pass without the refactoring. > > Urgent to review. > > > This addresses bug HBASE-2712. > http://issues.apache.org/jira/browse/HBASE-2712 > > > Diffs > ----- > > /trunk/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java > 953830 > /trunk/src/test/java/org/apache/hadoop/hbase/client/TestHCM.java > PRE-CREATION > > Diff: http://review.hbase.org/r/170/diff > > > Testing > ------- > > > Thanks, > > Jean-Daniel > >
