> On 2010-06-11 11:52:48, stack wrote: > > /branches/0.20/src/java/org/apache/hadoop/hbase/client/HConnectionManager.java, > > line 850 > > <http://review.hbase.org/r/170/diff/1/?file=1246#file1246line850> > > > > getCachedLocation does the right thing?
Yep, that one did, so that's why we should reuse it instead. > On 2010-06-11 11:52:48, stack wrote: > > /branches/0.20/src/java/org/apache/hadoop/hbase/client/HConnectionManager.java, > > line 851 > > <http://review.hbase.org/r/170/diff/1/?file=1246#file1246line851> > > > > rl will never be null? Doh - Jean-Daniel ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://review.hbase.org/r/170/#review188 ----------------------------------------------------------- On 2010-06-11 11:42:53, Jean-Daniel Cryans wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://review.hbase.org/r/170/ > ----------------------------------------------------------- > > (Updated 2010-06-11 11:42:53) > > > Review request for hbase. > > > Summary > ------- > > Patch against branch that does some refactoring and that fixes the bug at the > same time. Adds a unit test that doesn't pass without the refactoring. > > Urgent to review. > > > This addresses bug HBASE-2712. > http://issues.apache.org/jira/browse/HBASE-2712 > > > Diffs > ----- > > > /branches/0.20/src/java/org/apache/hadoop/hbase/client/HConnectionManager.java > 953796 > /branches/0.20/src/test/org/apache/hadoop/hbase/client/TestHCM.java > PRE-CREATION > > Diff: http://review.hbase.org/r/170/diff > > > Testing > ------- > > > Thanks, > > Jean-Daniel > >
