----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://review.hbase.org/r/180/#review229 -----------------------------------------------------------
Ship it! +1 I some minors in the below and then some questions but these should not get in way of a commit. src/main/java/org/apache/hadoop/hbase/KeyValue.java <http://review.hbase.org/r/180/#comment1016> Is this going to be correct always? Cloning, we don't want the src memstoreTS? src/main/java/org/apache/hadoop/hbase/KeyValue.java <http://review.hbase.org/r/180/#comment1017> What we going to do about N versions all of same r/f/q/ts but of different memstoreTS? We're not going to suppress them just yet? We're going to punt till hbase-1485? The multiple versions make it out to store files too? src/test/java/org/apache/hadoop/hbase/TestAcidGuarantees.java <http://review.hbase.org/r/180/#comment1018> Prefix w/ 'TODO' to make this work-to-do more findable. src/test/java/org/apache/hadoop/hbase/TestAcidGuarantees.java <http://review.hbase.org/r/180/#comment1019> Nice src/test/java/org/apache/hadoop/hbase/regionserver/TestStoreScanner.java <http://review.hbase.org/r/180/#comment1020> Go ahead and remove then boss. - stack On 2010-06-14 16:30:30, Todd Lipcon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://review.hbase.org/r/180/ > ----------------------------------------------------------- > > (Updated 2010-06-14 16:30:30) > > > Review request for hbase and Ryan Rawson. > > > Summary > ------- > > This changes the memstore comparator, improves the atomicity tests, and also > fixes ICV to continue to have the right behavior even with the comparator > change. > > > This addresses bug hbase-2670. > http://issues.apache.org/jira/browse/hbase-2670 > > > Diffs > ----- > > src/main/java/org/apache/hadoop/hbase/KeyValue.java 71284cf > src/main/java/org/apache/hadoop/hbase/regionserver/Store.java 2a0dcee > src/test/java/org/apache/hadoop/hbase/MultithreadedTestUtil.java 7c062d7 > src/test/java/org/apache/hadoop/hbase/TestAcidGuarantees.java 75f3c8b > src/test/java/org/apache/hadoop/hbase/regionserver/TestMemStore.java > 9833d76 > src/test/java/org/apache/hadoop/hbase/regionserver/TestStoreScanner.java > 0566af7 > > Diff: http://review.hbase.org/r/180/diff > > > Testing > ------- > > Unit tests. > > > Thanks, > > Todd > >
