----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://review.hbase.org/r/180/#review235 -----------------------------------------------------------
Ship it! ok looks good. I'm also prepping a new way to do ICVs in a different issue (HBASE-2501). src/main/java/org/apache/hadoop/hbase/KeyValue.java <http://review.hbase.org/r/180/#comment1066> the extra KVs will make it out to hfile, but considering the problem I just don't see a better solution right now. Perhaps collapsing extra version during the flush, but then the question is _which_ extra versions? Maybe this will lead us to using an extra timestamp in every KeyValue on disk and in memory, but I hope not. - Ryan On 2010-06-14 16:30:30, Todd Lipcon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://review.hbase.org/r/180/ > ----------------------------------------------------------- > > (Updated 2010-06-14 16:30:30) > > > Review request for hbase and Ryan Rawson. > > > Summary > ------- > > This changes the memstore comparator, improves the atomicity tests, and also > fixes ICV to continue to have the right behavior even with the comparator > change. > > > This addresses bug hbase-2670. > http://issues.apache.org/jira/browse/hbase-2670 > > > Diffs > ----- > > src/main/java/org/apache/hadoop/hbase/KeyValue.java 71284cf > src/main/java/org/apache/hadoop/hbase/regionserver/Store.java 2a0dcee > src/test/java/org/apache/hadoop/hbase/MultithreadedTestUtil.java 7c062d7 > src/test/java/org/apache/hadoop/hbase/TestAcidGuarantees.java 75f3c8b > src/test/java/org/apache/hadoop/hbase/regionserver/TestMemStore.java > 9833d76 > src/test/java/org/apache/hadoop/hbase/regionserver/TestStoreScanner.java > 0566af7 > > Diff: http://review.hbase.org/r/180/diff > > > Testing > ------- > > Unit tests. > > > Thanks, > > Todd > >
