----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://review.hbase.org/r/328/#review414 -----------------------------------------------------------
Ship it! This looks nice Nicolas. Want to take care of the few below and I'll then commit? trunk/bin/local-master-backup.sh <http://review.hbase.org/r/328/#comment1761> Why is it called local-master-backup? Should be a more descriptive name? Its the 'backup' that throws me off. 'local-masters'? trunk/bin/local-master-backup.sh <http://review.hbase.org/r/328/#comment1762> Explain 'offset' in this usage output? (Seems to be port offset from default?) trunk/bin/local-master-backup.sh <http://review.hbase.org/r/328/#comment1763> Isn't the master default port 60000, not 60020? 60020 is RS default port? trunk/conf/hbase-site.xml.psuedo-distributed <http://review.hbase.org/r/328/#comment1767> This is commented out because dfs.support.append doesn't work with local fs? trunk/src/main/java/org/apache/hadoop/hbase/master/HMaster.java <http://review.hbase.org/r/328/#comment1768> You are adding a tab here? Or white-space? trunk/src/main/java/org/apache/hadoop/hbase/master/HMaster.java <http://review.hbase.org/r/328/#comment1769> Add more comment in here... in particular on the '-splitting' suffix. Where's that come from? trunk/src/main/java/org/apache/hadoop/hbase/master/HMaster.java <http://review.hbase.org/r/328/#comment1770> Tab? trunk/src/main/java/org/apache/hadoop/hbase/master/HMaster.java <http://review.hbase.org/r/328/#comment1772> There is whitespace in here. trunk/src/main/java/org/apache/hadoop/hbase/master/HMaster.java <http://review.hbase.org/r/328/#comment1773> Sorry Nicolas... this looks like an old unused option. Should probably remove it. trunk/src/main/java/org/apache/hadoop/hbase/master/HMaster.java <http://review.hbase.org/r/328/#comment1774> This is a nice addition. trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java <http://review.hbase.org/r/328/#comment1775> White space - stack On 2010-07-15 22:42:55, Nicolas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://review.hbase.org/r/328/ > ----------------------------------------------------------- > > (Updated 2010-07-15 22:42:55) > > > Review request for hbase. > > > Summary > ------- > > Pseudo-distributed mode for HBase > > * separate processes for Master & RS > * script to add more RS in a psuedo-distributed cluster > * script to add backup masters in a psudo-distributed cluster > * config file that > a. explains basic psuedo-distributed mode settings > b. shows the extra options to add for running on top of pseudo-distributed > HDFS > > Note that I needed to add a GNU Parsing utility to the master + regionserver > so I could override certain config values on the fly instead of making > seperate config files. > > > This addresses bug HBASE-1511. > http://issues.apache.org/jira/browse/HBASE-1511 > > > Diffs > ----- > > trunk/bin/local-master-backup.sh PRE-CREATION > trunk/bin/local-regionservers.sh PRE-CREATION > trunk/conf/hbase-site.xml.psuedo-distributed PRE-CREATION > trunk/src/main/java/org/apache/hadoop/hbase/master/HMaster.java 964686 > trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java > 964686 > > Diff: http://review.hbase.org/r/328/diff > > > Testing > ------- > > > Thanks, > > Nicolas > >
