----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://review.hbase.org/r/329/#review419 -----------------------------------------------------------
Ship it! Brief comments: - radix sort in the list of files - <= on the sequence id to discard - some trailing whitespace +1 lgtm - Ryan On 2010-07-16 13:03:14, stack wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://review.hbase.org/r/329/ > ----------------------------------------------------------- > > (Updated 2010-07-16 13:03:14) > > > Review request for hbase and Ryan Rawson. > > > Summary > ------- > > See notes made over in hbase-2727 > > > This addresses bug hbase-2727. > http://issues.apache.org/jira/browse/hbase-2727 > > > Diffs > ----- > > src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java 40205c4 > src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLog.java 7044891 > src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestHLogMethods.java > PRE-CREATION > src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestHLogSplit.java > 3fff2fa > src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestWALReplay.java > 9053d39 > > Diff: http://review.hbase.org/r/329/diff > > > Testing > ------- > > All related tests seem to pass. A few are failing for me but seem unrelated. > Digging in while this review goes on. > > > Thanks, > > stack > >
