----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://review.hbase.org/r/332/#review421 -----------------------------------------------------------
Ship it! +1 - stack On 2010-07-16 16:15:46, Ryan Rawson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://review.hbase.org/r/332/ > ----------------------------------------------------------- > > (Updated 2010-07-16 16:15:46) > > > Review request for hbase. > > > Summary > ------- > > Remove the final remnants of the old Get code - the query matchers and other > helper classes > > > This addresses bug HBASE-2840. > http://issues.apache.org/jira/browse/HBASE-2840 > > > Diffs > ----- > > src/main/java/org/apache/hadoop/hbase/regionserver/ColumnTracker.java > 35b03a1 > src/main/java/org/apache/hadoop/hbase/regionserver/DeleteCompare.java > 11da530 > > src/main/java/org/apache/hadoop/hbase/regionserver/ExplicitColumnTracker.java > 37bbee0 > > src/main/java/org/apache/hadoop/hbase/regionserver/GetClosestRowBeforeTracker.java > 52fbbd3 > src/main/java/org/apache/hadoop/hbase/regionserver/GetDeleteTracker.java > 8e68d65 > src/main/java/org/apache/hadoop/hbase/regionserver/MemStore.java 8f61df3 > src/main/java/org/apache/hadoop/hbase/regionserver/QueryMatcher.java > a8dcfab > src/main/java/org/apache/hadoop/hbase/regionserver/ScanQueryMatcher.java > c805bfa > > src/main/java/org/apache/hadoop/hbase/regionserver/ScanWildcardColumnTracker.java > a32d6e3 > src/main/java/org/apache/hadoop/hbase/regionserver/StoreFileGetScan.java > 4d2e742 > src/main/java/org/apache/hadoop/hbase/regionserver/StoreScanner.java > e49a0f0 > > src/main/java/org/apache/hadoop/hbase/regionserver/WildcardColumnTracker.java > 0e673c4 > src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java 8fc0766 > src/test/java/org/apache/hadoop/hbase/regionserver/TestDeleteCompare.java > 6ea4a1c > > src/test/java/org/apache/hadoop/hbase/regionserver/TestExplicitColumnTracker.java > 8c38a42 > > src/test/java/org/apache/hadoop/hbase/regionserver/TestGetDeleteTracker.java > c8d7680 > src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java 96b51e7 > src/test/java/org/apache/hadoop/hbase/regionserver/TestQueryMatcher.java > 3670450 > > src/test/java/org/apache/hadoop/hbase/regionserver/TestScanWildcardColumnTracker.java > 2ff5a25 > > src/test/java/org/apache/hadoop/hbase/regionserver/TestWildcardColumnTracker.java > 195744a > > Diff: http://review.hbase.org/r/332/diff > > > Testing > ------- > > > Thanks, > > Ryan > >
