----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://review.hbase.org/r/336/#review425 -----------------------------------------------------------
trunk/src/test/java/org/apache/hadoop/hbase/client/TestBloomFilter.java <http://review.hbase.org/r/336/#comment1794> can you rework this test not to use TEST_UTIL and starting up a mini-hbase cluster? For alternate options, try doing what HRegion does, which is to instantiate a HRegion then use the HRegion API calls instead. - Ryan On 2010-07-19 18:07:22, Pranav Khaitan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://review.hbase.org/r/336/ > ----------------------------------------------------------- > > (Updated 2010-07-19 18:07:22) > > > Review request for hbase, Nicolas, Karthik Ranganathan, and Kannan > Muthukkaruppan. > > > Summary > ------- > > Fixed bloom filter code in StoreFile > > > This addresses bug HBASE-2852. > http://issues.apache.org/jira/browse/HBASE-2852 > > > Diffs > ----- > > trunk/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFile.java > 965615 > trunk/src/test/java/org/apache/hadoop/hbase/client/TestBloomFilter.java > PRE-CREATION > > Diff: http://review.hbase.org/r/336/diff > > > Testing > ------- > > JUnit tests added > > > Thanks, > > Pranav > >
