> On 2010-07-26 18:25:37, Jonathan Gray wrote: > > Just a simple null check and added test. LGTM
and all of ryan's comments have been addressed. thanks pranav. - Jonathan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://review.hbase.org/r/336/#review492 ----------------------------------------------------------- On 2010-07-21 23:04:10, Pranav Khaitan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://review.hbase.org/r/336/ > ----------------------------------------------------------- > > (Updated 2010-07-21 23:04:10) > > > Review request for hbase, Nicolas, Karthik Ranganathan, and Kannan > Muthukkaruppan. > > > Summary > ------- > > Fixed bloom filter code in StoreFile > > > This addresses bug HBASE-2852. > http://issues.apache.org/jira/browse/HBASE-2852 > > > Diffs > ----- > > trunk/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFile.java > 965615 > trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java > 965615 > > Diff: http://review.hbase.org/r/336/diff > > > Testing > ------- > > JUnit tests added > > > Thanks, > > Pranav > >
