----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://review.hbase.org/r/370/#review467 -----------------------------------------------------------
Hey Alex, this is looking good. The master rewrite branch has a refactoring of ZooKeeperWrapper and general ZK usage inside HBase that conflicts with this pretty significantly. Do you think you could pull the new methods and classes nested in ZooKeeperWrapper into a separate class of static methods? If you need the instantiated instance of ZKW, pass it in as the first argument to the static methods? That will make my life WAY easier when I have to merge the branch back into trunk. Also gives an opportunity to have a class comment in the new class explaining the overall usage of zk. Stuff like the names of the nodes can be left in the instantiated ZKW class since it makes sense to pull those in from the confs on instantiation. Cool? Let me know if you want an example. - Jonathan On 2010-07-22 17:25:12, Alex Newman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://review.hbase.org/r/370/ > ----------------------------------------------------------- > > (Updated 2010-07-22 17:25:12) > > > Review request for hbase. > > > Summary > ------- > > This build on the previous work. It does some smarter stuff with testing and > now splitting is configurable. > > > This addresses bug hbase-1364. > http://issues.apache.org/jira/browse/hbase-1364 > > > Diffs > ----- > > src/main/java/org/apache/hadoop/hbase/HConstants.java c77ebf5 > src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java > f251d54 > src/main/java/org/apache/hadoop/hbase/regionserver/LogSplitter.java > PRE-CREATION > src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLog.java 5688c03 > src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperWrapper.java > 8225178 > src/main/resources/hbase-default.xml e3a9669 > > src/test/java/org/apache/hadoop/hbase/regionserver/wal/BaseTestHLogSplit.java > PRE-CREATION > > src/test/java/org/apache/hadoop/hbase/regionserver/wal/DistributedTestHLog.java > PRE-CREATION > > src/test/java/org/apache/hadoop/hbase/regionserver/wal/DistributedTestHLogSplit.java > PRE-CREATION > > src/test/java/org/apache/hadoop/hbase/regionserver/wal/DistributedTestHLogSplitSkipErrors.java > PRE-CREATION > > src/test/java/org/apache/hadoop/hbase/regionserver/wal/DistributedTestLogRolling.java > PRE-CREATION > src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestHLog.java > ad8f9e5 > src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestHLogSplit.java > 908633e > > src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestHLogSplitSkipErrors.java > PRE-CREATION > > src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestLogActionsListener.java > 776d78c > src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestLogRolling.java > 9eae4b4 > src/test/resources/hbase-site.xml 3c0601a > > Diff: http://review.hbase.org/r/370/diff > > > Testing > ------- > > ran on our private hudson > > > Thanks, > > Alex > >
