> On 2010-07-23 12:01:53, Jean-Daniel Cryans wrote: > > First pass on this patch. Lots of cleanup that needs to be done, and it's a > > bit hard to follow the flow of events without any clear documentation that > > gives an overview of distributed splitting. Nothing big, just some use > > cases that could be put in the class javadoc of LogSplitter?
I'll add the story and get these changes in. - Alex ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://review.hbase.org/r/370/#review464 ----------------------------------------------------------- On 2010-07-22 17:25:12, Alex Newman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://review.hbase.org/r/370/ > ----------------------------------------------------------- > > (Updated 2010-07-22 17:25:12) > > > Review request for hbase. > > > Summary > ------- > > This build on the previous work. It does some smarter stuff with testing and > now splitting is configurable. > > > This addresses bug hbase-1364. > http://issues.apache.org/jira/browse/hbase-1364 > > > Diffs > ----- > > src/main/java/org/apache/hadoop/hbase/HConstants.java c77ebf5 > src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java > f251d54 > src/main/java/org/apache/hadoop/hbase/regionserver/LogSplitter.java > PRE-CREATION > src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLog.java 5688c03 > src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperWrapper.java > 8225178 > src/main/resources/hbase-default.xml e3a9669 > > src/test/java/org/apache/hadoop/hbase/regionserver/wal/BaseTestHLogSplit.java > PRE-CREATION > > src/test/java/org/apache/hadoop/hbase/regionserver/wal/DistributedTestHLog.java > PRE-CREATION > > src/test/java/org/apache/hadoop/hbase/regionserver/wal/DistributedTestHLogSplit.java > PRE-CREATION > > src/test/java/org/apache/hadoop/hbase/regionserver/wal/DistributedTestHLogSplitSkipErrors.java > PRE-CREATION > > src/test/java/org/apache/hadoop/hbase/regionserver/wal/DistributedTestLogRolling.java > PRE-CREATION > src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestHLog.java > ad8f9e5 > src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestHLogSplit.java > 908633e > > src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestHLogSplitSkipErrors.java > PRE-CREATION > > src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestLogActionsListener.java > 776d78c > src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestLogRolling.java > 9eae4b4 > src/test/resources/hbase-site.xml 3c0601a > > Diff: http://review.hbase.org/r/370/diff > > > Testing > ------- > > ran on our private hudson > > > Thanks, > > Alex > >
