-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/925/
-----------------------------------------------------------

(Updated 2010-09-29 19:40:41.579973)


Review request for hbase, stack, Karthik Ranganathan, and Kannan Muthukkaruppan.


Changes
-------

Adds some more methods into MiniHBaseCluster.

Adds a new unit test, TestMultipleMasters.

All the existing unit tests I ran seem to work fine, but TestMultipleMasters 
does not work right.  Once the second master gets to where he sees there is 
another master and then blocks waiting, nothing proceeds.  Not really sure 
what's up yet.


Summary
-------

To really be able to unit test the new master properly, we need to be able to 
have multiple masters running at once within a single logical cluster.

Also exposes methods to get the currently active master and can access each 
individually in the same way that it's done for multiple RS.

This is mostly duplicating what we do for RS but for masters.


This addresses bug HBASE-3053.
    http://issues.apache.org/jira/browse/HBASE-3053


Diffs (updated)
-----

  trunk/src/main/java/org/apache/hadoop/hbase/HConstants.java 1002883 
  trunk/src/main/java/org/apache/hadoop/hbase/LocalHBaseCluster.java 1002883 
  trunk/src/main/java/org/apache/hadoop/hbase/master/HMaster.java 1002883 
  trunk/src/main/java/org/apache/hadoop/hbase/master/HMasterCommandLine.java 
1002883 
  trunk/src/main/java/org/apache/hadoop/hbase/util/JVMClusterUtil.java 1002883 
  trunk/src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java 1002883 
  trunk/src/test/java/org/apache/hadoop/hbase/MiniHBaseCluster.java 1002883 
  trunk/src/test/java/org/apache/hadoop/hbase/master/TestMultipleMasters.java 
PRE-CREATION 

Diff: http://review.cloudera.org/r/925/diff


Testing
-------

Untested but compiles.  This is first go at a patch.  I'm going to work on 
writing a new unit test that uses this next.


Thanks,

Jonathan

Reply via email to