-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/925/
-----------------------------------------------------------
(Updated 2010-10-05 18:15:55.818277)
Review request for hbase, stack, Karthik Ranganathan, and Kannan Muthukkaruppan.
Changes
-------
Incorporates changes from stack review.
Test itself is the same. I'd like to get this committed and then will work on
more tests as a separate JIRA. The changes to HMaster and HRS are hard to keep
up to date with trunk and I'll be doing more tests w/ this stuff over the next
two weeks.
Summary
-------
To really be able to unit test the new master properly, we need to be able to
have multiple masters running at once within a single logical cluster.
Also exposes methods to get the currently active master and can access each
individually in the same way that it's done for multiple RS.
This is mostly duplicating what we do for RS but for masters.
This addresses bug HBASE-3053.
http://issues.apache.org/jira/browse/HBASE-3053
Diffs (updated)
-----
trunk/src/main/java/org/apache/hadoop/hbase/HConstants.java 1004853
trunk/src/main/java/org/apache/hadoop/hbase/LocalHBaseCluster.java 1004853
trunk/src/main/java/org/apache/hadoop/hbase/master/HMaster.java 1004853
trunk/src/main/java/org/apache/hadoop/hbase/master/HMasterCommandLine.java
1004853
trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
1004853
trunk/src/main/java/org/apache/hadoop/hbase/util/JVMClusterUtil.java 1004853
trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperWatcher.java
1004853
trunk/src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java 1004853
trunk/src/test/java/org/apache/hadoop/hbase/MiniHBaseCluster.java 1004853
trunk/src/test/java/org/apache/hadoop/hbase/master/TestMasterFailover.java
PRE-CREATION
Diff: http://review.cloudera.org/r/925/diff
Testing
-------
Untested but compiles. This is first go at a patch. I'm going to work on
writing a new unit test that uses this next.
Thanks,
Jonathan
