----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/963/#review1427 -----------------------------------------------------------
Just javadoc cleanup, otherwise this looks great. As noted in comments, I think we should deprecate sorted(), recommend and @link to raw(), and ensure we aren't using sorted() internally (especially since it actually is less efficient w/ the assert). trunk/src/main/java/org/apache/hadoop/hbase/client/Result.java <http://review.cloudera.org/r/963/#comment4982> You might {...@link to KV.Comparator so javadoc for that can show up on hover trunk/src/main/java/org/apache/hadoop/hbase/client/Result.java <http://review.cloudera.org/r/963/#comment4981> > 80 trunk/src/main/java/org/apache/hadoop/hbase/client/Result.java <http://review.cloudera.org/r/963/#comment4983> Add @deprecated and then recommend using raw instead w/ an @link to it trunk/src/main/java/org/apache/hadoop/hbase/client/Result.java <http://review.cloudera.org/r/963/#comment4984> Should be "Returns the" or "Return the" rather than 'me'. Also >80 chars trunk/src/main/java/org/apache/hadoop/hbase/client/Result.java <http://review.cloudera.org/r/963/#comment4985> @link trunk/src/main/java/org/apache/hadoop/hbase/client/Result.java <http://review.cloudera.org/r/963/#comment4986> Should use raw()? trunk/src/main/java/org/apache/hadoop/hbase/client/Result.java <http://review.cloudera.org/r/963/#comment4987> >80 trunk/src/main/java/org/apache/hadoop/hbase/client/Result.java <http://review.cloudera.org/r/963/#comment4988> Maybe "Returns (or Gets) the KeyValue of the most recent version of the specified column"... and >80 - Jonathan On 2010-10-05 15:39:19, Ryan Rawson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://review.cloudera.org/r/963/ > ----------------------------------------------------------- > > (Updated 2010-10-05 15:39:19) > > > Review request for hbase. > > > Summary > ------- > > New APIs for Result, faster implementation for some calls > > > This addresses bug HBASE-3073. > http://issues.apache.org/jira/browse/HBASE-3073 > > > Diffs > ----- > > trunk/CHANGES.txt 1003710 > trunk/src/main/java/org/apache/hadoop/hbase/client/Result.java 1003710 > trunk/src/test/java/org/apache/hadoop/hbase/HBaseTestCase.java 1003709 > trunk/src/test/java/org/apache/hadoop/hbase/client/TestResult.java > PRE-CREATION > > Diff: http://review.cloudera.org/r/963/diff > > > Testing > ------- > > > Thanks, > > Ryan > >
