> On 2010-10-05 16:25:58, Ryan Rawson wrote: > > trunk/src/main/java/org/apache/hadoop/hbase/client/Result.java, line 202 > > <http://review.cloudera.org/r/963/diff/1/?file=14002#file14002line202> > > > > after https://issues.apache.org/jira/browse/HBASE-2753 is resolved, > > raw()===sort() and there wont be a difference.
Okay. Just saying, weird to use a deprecated method internally but agree that it doesn't matter if you're planning to remove the assert. - Jonathan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/963/#review1428 ----------------------------------------------------------- On 2010-10-05 15:39:19, Ryan Rawson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://review.cloudera.org/r/963/ > ----------------------------------------------------------- > > (Updated 2010-10-05 15:39:19) > > > Review request for hbase. > > > Summary > ------- > > New APIs for Result, faster implementation for some calls > > > This addresses bug HBASE-3073. > http://issues.apache.org/jira/browse/HBASE-3073 > > > Diffs > ----- > > trunk/CHANGES.txt 1003710 > trunk/src/main/java/org/apache/hadoop/hbase/client/Result.java 1003710 > trunk/src/test/java/org/apache/hadoop/hbase/HBaseTestCase.java 1003709 > trunk/src/test/java/org/apache/hadoop/hbase/client/TestResult.java > PRE-CREATION > > Diff: http://review.cloudera.org/r/963/diff > > > Testing > ------- > > > Thanks, > > Ryan > >