> On 2010-10-18 14:16:08, Ted Yu wrote: > > trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java, > > line 2388 > > <http://review.cloudera.org/r/1038/diff/1/?file=14871#file14871line2388> > > > > Please translate error status code to result
Result objects are always 'successful', because normally in a Get or Scan/next call you get the Result or an exception via a throw. So it is impossible to translate an error code into a Result object, which is what is needed here. - Ryan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/1038/#review1557 ----------------------------------------------------------- On 2010-10-18 13:42:36, Ryan Rawson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://review.cloudera.org/r/1038/ > ----------------------------------------------------------- > > (Updated 2010-10-18 13:42:36) > > > Review request for hbase. > > > Summary > ------- > > This fixes multi() to call the batch-versions of Put in HRegion to reclaim > performance. > > > This addresses bug HBASE-2985. > http://issues.apache.org/jira/browse/HBASE-2985 > > > Diffs > ----- > > trunk/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java > 1023115 > trunk/src/main/java/org/apache/hadoop/hbase/client/MultiResponse.java > 1023115 > trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java > 1023115 > > Diff: http://review.cloudera.org/r/1038/diff > > > Testing > ------- > > > Thanks, > > Ryan > >
