----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/1038/#review1566 -----------------------------------------------------------
Ship it! +1 except for all the crud that you left in the patch... please clean before commit (Do tests pass)? trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java <http://review.cloudera.org/r/1038/#comment5273> Remove this message on commit trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java <http://review.cloudera.org/r/1038/#comment5274> Ugh. Remove this too. trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java <http://review.cloudera.org/r/1038/#comment5275> This too. trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java <http://review.cloudera.org/r/1038/#comment5276> This! trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java <http://review.cloudera.org/r/1038/#comment5277> This. - stack On 2010-10-18 13:42:36, Ryan Rawson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://review.cloudera.org/r/1038/ > ----------------------------------------------------------- > > (Updated 2010-10-18 13:42:36) > > > Review request for hbase. > > > Summary > ------- > > This fixes multi() to call the batch-versions of Put in HRegion to reclaim > performance. > > > This addresses bug HBASE-2985. > http://issues.apache.org/jira/browse/HBASE-2985 > > > Diffs > ----- > > trunk/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java > 1023115 > trunk/src/main/java/org/apache/hadoop/hbase/client/MultiResponse.java > 1023115 > trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java > 1023115 > > Diff: http://review.cloudera.org/r/1038/diff > > > Testing > ------- > > > Thanks, > > Ryan > >
