----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/1053/#review1586 -----------------------------------------------------------
Just some minor comments. src/main/java/org/apache/hadoop/hbase/regionserver/ControlledScan.java <http://review.cloudera.org/r/1053/#comment5387> This class doesn't need to be public, make it package-private. src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java <http://review.cloudera.org/r/1053/#comment5389> The style used in HBase mandates that this method be named getLastIncrement. src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java <http://review.cloudera.org/r/1053/#comment5388> A `//'-style comment would be better here src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java <http://review.cloudera.org/r/1053/#comment5390> use if (!results.isEmpty()) src/main/java/org/apache/hadoop/hbase/regionserver/StoreScanner.java <http://review.cloudera.org/r/1053/#comment5391> Instead of two nested `if', you could combine both conditions with `&&' - Benoit On 2010-10-20 11:45:51, khemani wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://review.cloudera.org/r/1053/ > ----------------------------------------------------------- > > (Updated 2010-10-20 11:45:51) > > > Review request for hbase and Jonathan Gray. > > > Summary > ------- > > Ensure that during incrementColumnValue() the scan triggered by the get() > does an early exit if it finds the KV in the memstore. > > > This addresses bug HBASE-3082. > http://issues.apache.org/jira/browse/HBASE-3082 > > > Diffs > ----- > > src/main/java/org/apache/hadoop/hbase/regionserver/ControlledScan.java > PRE-CREATION > src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java 0e3940c > src/main/java/org/apache/hadoop/hbase/regionserver/StoreScanner.java > 4775fc8 > > Diff: http://review.cloudera.org/r/1053/diff > > > Testing > ------- > > I have been testing it on my cluster. No unit testing yet. > > > Thanks, > > khemani > >
