> On 2010-10-20 21:41:23, Ryan Rawson wrote: > > src/main/java/org/apache/hadoop/hbase/regionserver/StoreScanner.java, line > > 155 > > <http://review.cloudera.org/r/1053/diff/2/?file=15063#file15063line155> > > > > Would this code be cleaner if we didnt have to use instanceof? > > khemani wrote: > yes, i agree it will be cleaner w/o instanceof. But in that case we will > have to pass the flags all the way from HRegion to StoreScanner. A number of > signatures will have to change. > > Another approach could be to only instantiate InternalScan in the server > side. But again that is quite a bit of code change. > > Having an internal-scan should be useful. After all, a scan touches a lot > of data and certain other tasks can potentially be piggybacked on a scan.
ok that makes sense. let's go with it then. - Ryan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/1053/#review1596 ----------------------------------------------------------- On 2010-10-20 21:31:17, khemani wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://review.cloudera.org/r/1053/ > ----------------------------------------------------------- > > (Updated 2010-10-20 21:31:17) > > > Review request for hbase and Jonathan Gray. > > > Summary > ------- > > Ensure that during incrementColumnValue() the scan triggered by the get() > does an early exit if it finds the KV in the memstore. > > > This addresses bug HBASE-3082. > http://issues.apache.org/jira/browse/HBASE-3082 > > > Diffs > ----- > > src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java 0e3940c > src/main/java/org/apache/hadoop/hbase/regionserver/InternalScan.java > PRE-CREATION > src/main/java/org/apache/hadoop/hbase/regionserver/StoreScanner.java > 4775fc8 > > Diff: http://review.cloudera.org/r/1053/diff > > > Testing > ------- > > I have been testing it on my cluster. No unit testing yet. > > > Thanks, > > khemani > >
