----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/1090/#review1688 -----------------------------------------------------------
Ship it! +1 Looks great. A nice little bomb thrown into the midst of new master. trunk/src/main/java/org/apache/hadoop/hbase/LocalHBaseCluster.java <http://review.cloudera.org/r/1090/#comment5586> You sure the RS you find here is same as the one you passed in? Do rst.getRegionServer. trunk/src/main/java/org/apache/hadoop/hbase/LocalHBaseCluster.java <http://review.cloudera.org/r/1090/#comment5587> Ditto here. trunk/src/main/java/org/apache/hadoop/hbase/catalog/CatalogTracker.java <http://review.cloudera.org/r/1090/#comment5588> This is fine but maybe we should make the equating sloppier... just do a contains 'Connection reset'? trunk/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java <http://review.cloudera.org/r/1090/#comment5589> This is important trunk/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java <http://review.cloudera.org/r/1090/#comment5590> Good trunk/src/main/java/org/apache/hadoop/hbase/master/HMaster.java <http://review.cloudera.org/r/1090/#comment5591> good trunk/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java <http://review.cloudera.org/r/1090/#comment5592> Isn't there an accessor for this? Why you need to make this non-private? trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java <http://review.cloudera.org/r/1090/#comment5593> Good trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java <http://review.cloudera.org/r/1090/#comment5594> Add this string to the one above... to the 'Serving as' string.. its trying to be all vital statistics about an HRS post construction. trunk/src/test/java/org/apache/hadoop/hbase/master/TestRollingRestart.java <http://review.cloudera.org/r/1090/#comment5595> oh nelly - stack On 2010-10-28 12:00:06, Jonathan Gray wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://review.cloudera.org/r/1090/ > ----------------------------------------------------------- > > (Updated 2010-10-28 12:00:06) > > > Review request for hbase and stack. > > > Summary > ------- > > First go at a TestRollingRestart. Needs more work / harder tests per > comments in the test. > > > Diffs > ----- > > trunk/src/main/java/org/apache/hadoop/hbase/LocalHBaseCluster.java 1027683 > trunk/src/main/java/org/apache/hadoop/hbase/catalog/CatalogTracker.java > 1027683 > trunk/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java > 1027683 > trunk/src/main/java/org/apache/hadoop/hbase/master/HMaster.java 1027683 > trunk/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java > 1027683 > trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java > 1027683 > trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKAssign.java 1027683 > trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java 1027683 > trunk/src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java > 1027683 > trunk/src/test/java/org/apache/hadoop/hbase/master/TestRollingRestart.java > PRE-CREATION > > Diff: http://review.cloudera.org/r/1090/diff > > > Testing > ------- > > > Thanks, > > Jonathan > >
