> On 2010-10-28 13:43:01, stack wrote: > > +1 Looks great. A nice little bomb thrown into the midst of new master. > > stack wrote: > Oh, reconcile this patch with the one I just posted here on rb. Add in > the extra logging in close and open handlers in particular. Helps debugging > knowing which handler for which server is running. > > Jonathan Gray wrote: > Will make your changes from below on commit. Thanks for review Stack!
Okay. This is enough changes to warrant another post to RB. Let me do the changes from your review, bring in your logging changes, and put up new diff on rb. - Jonathan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/1090/#review1688 ----------------------------------------------------------- On 2010-10-28 12:00:06, Jonathan Gray wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://review.cloudera.org/r/1090/ > ----------------------------------------------------------- > > (Updated 2010-10-28 12:00:06) > > > Review request for hbase and stack. > > > Summary > ------- > > First go at a TestRollingRestart. Needs more work / harder tests per > comments in the test. > > > Diffs > ----- > > trunk/src/main/java/org/apache/hadoop/hbase/LocalHBaseCluster.java 1027683 > trunk/src/main/java/org/apache/hadoop/hbase/catalog/CatalogTracker.java > 1027683 > trunk/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java > 1027683 > trunk/src/main/java/org/apache/hadoop/hbase/master/HMaster.java 1027683 > trunk/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java > 1027683 > trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java > 1027683 > trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKAssign.java 1027683 > trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java 1027683 > trunk/src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java > 1027683 > trunk/src/test/java/org/apache/hadoop/hbase/master/TestRollingRestart.java > PRE-CREATION > > Diff: http://review.cloudera.org/r/1090/diff > > > Testing > ------- > > > Thanks, > > Jonathan > >
