----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/1089/#review1904 -----------------------------------------------------------
Ship it! Looks good to me. Have you tested it works? Or, you want to write a unit test at least for the reading/writing of the new file? - stack On 2010-11-10 17:04:39, Jonathan Gray wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://review.cloudera.org/r/1089/ > ----------------------------------------------------------- > > (Updated 2010-11-10 17:04:39) > > > Review request for hbase, stack and khemani. > > > Summary > ------- > > This is a somewhat misguided attempt. It's not done but it shows the fairly > simple change to the actual major compaction code. > > The hard part is: > > + long lastMajor = region.getRegionInfo().getRegionData().getLastMajor(); > > And the question is where to persist that. > > This patch adds a new class called HRegionData into HRegionInfo that contains > any number of key-value pairs of data that get persisted with the HRI. Not > really sure how I ended up there but this data seemed like an odd-man-out so > adding another field seemed weird. We also need some kind of versioning in > HRI so we can add stuff w/o migrating. There's some versioned stuff in > HRData. > > Just looking for some feedback / ideas. > > > This addresses bugs HBASE-2990 and HBASE-3083. > http://issues.apache.org/jira/browse/HBASE-2990 > http://issues.apache.org/jira/browse/HBASE-3083 > > > Diffs > ----- > > trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java > 1033780 > trunk/src/main/java/org/apache/hadoop/hbase/regionserver/Store.java 1033780 > > Diff: http://review.cloudera.org/r/1089/diff > > > Testing > ------- > > > Thanks, > > Jonathan > >
